search

pittcsc / PantherView

Spring semester Open Data club project: PantherView
http://pittcsc.org/PantherView/
MIT License
24 stars 24 forks source link

Add location services #100

Closed nicoledaniels closed 7 years ago

nicoledaniels commented 7 years ago

Implemented geolocation for the map. If the user provides their location, the map will center itself on their longitude and latitude. To make pins near the user easier to see, the map will also zoom in to 17 instead of 15. If the user does not have geolocation services or declines to give their location, set the center of the map to Cathy and keep the zoom at 15. Closes #99

Also, added my name to the contributors list

vonbearshark commented 7 years ago

There seems to be this weird bug on Firefox that if a user selects "Not Now", the error function is never called: https://bugzilla.mozilla.org/show_bug.cgi?id=675533

vonbearshark commented 7 years ago

Likewise, Chrome only supports geolocation through https, which we don't have on our custom domain (which is also a GH Pages site) right now: https://developers.google.com/web/updates/2016/04/geolocation-on-secure-contexts-only. We'll need to set that up first.

vonbearshark commented 7 years ago

I reverted this PR, but you might be able to actually open it back up @nicoledaniels, because I can't seem to.

nicoledaniels commented 7 years ago

Don't think you can re-open merged and then un-merged PRs http://stackoverflow.com/questions/12674304/github-reopening-a-merged-pull-request

vonbearshark commented 7 years ago

shrug. I reopened #99