search

pittcsc / PantherView

Spring semester Open Data club project: PantherView
http://pittcsc.org/PantherView/
MIT License
24 stars 24 forks source link

Resolve Issue 95: Added SQL to prune 311 data to most recent 30 days #123

Closed BenjaminMuscato closed 7 years ago

BenjaminMuscato commented 7 years ago

Updated the SQL query for gathering 311 data, to limit the data returned to be from the most recent 30 days.

Also removed the arbitrary limitation that had been on the 311 data, which limited it to gather the 250 most recent records.

vonbearshark commented 7 years ago

@BenjaminMuscato did you get a chance to run your tests? Before you commit again, you'll need to merge in the recent changes, which separate some constants into another JS file. Also, could you remove this block of code https://github.com/Pitt-CSC/PantherView/blob/master/main.js#L264 ? Since you've made it unnecessary. You can also remove the TODO comment on line 204, too.

vonbearshark commented 7 years ago

Looks great! If you take out those TODO comments I can merge it in!

BenjaminMuscato commented 7 years ago

@vonbearshark I've removed the "TODO" comments, I think the PR is ready to go.

I didn't touch any of the JS filtering that's currently in place, since I think we still need it in its current form to filter through the data even after we've gotten it from the database (to show by Day, Week, and Month in the GUI).

vonbearshark commented 7 years ago

Great work, @BenjaminMuscato. Thanks a lot! This is a good addition