search

pittcsc / PantherView

Spring semester Open Data club project: PantherView
http://pittcsc.org/PantherView/
MIT License
24 stars 24 forks source link

Fixed data update notification variable #126

Closed seifriedc closed 7 years ago

seifriedc commented 7 years ago

Screwed up the last PR, my bad

seifriedc commented 7 years ago

Ah I'm getting another error, standby

seifriedc commented 7 years ago

Looks good now

vonbearshark commented 7 years ago

So it still looks like we're using the range constant versus adding a range (or whatever) property to the WPRDC_DATA_SOURCES objects--do you want to set that up in this PR?

vonbearshark commented 7 years ago

It otherwise looks good

seifriedc commented 7 years ago

Oh yeah I was gonna do that in a separate PR. I have it done though; I'll submit it today when I get a chance

vonbearshark commented 7 years ago

Awesome code--looks really slick. Looks like there's a conflict, but I'll be happy to merge it in after you fix the merge conflicts

seifriedc commented 7 years ago

Cool thanks!