search

pittcsc / PantherView

Spring semester Open Data club project: PantherView
http://pittcsc.org/PantherView/
MIT License
24 stars 24 forks source link

Updated library and 311 WPRDC IDs and Sidebar fix #142

Closed seifriedc closed 6 years ago

seifriedc commented 6 years ago

Fixed GET errors, data shows up on the map without errors now. Also made the sidebar closed on mobile by default to close #136.

kingsman142 commented 6 years ago 
//Start with sidebar closed if mobile
if (screen.width <= 800) {
         sidebarToggle.open = 1;
         ...
 }

Are you sure this closes the sidebar? Wouldn't open = 1 mean the sidebar is opened by default? I also saw above this you have:

58. sidebarToggle.open = 1;

This indicates the sidebar will initially be open on both mobile and desktop by default. Therefore, this line is no longer needed if we set sidebarToggle.open = 1 in the following if statements that you moved.

seifriedc commented 6 years ago

Yes, sorry you're right on both accounts. First one might have been a typo. I'll fix this real quick

kingsman142 commented 6 years ago

@seifriedc Looks good to me. I checked both of your previous two commits. Merging...