pittcsc / PantherView

Spring semester Open Data club project: PantherView
http://pittcsc.org/PantherView/
MIT License
24 stars 24 forks source link

Pin Logos #25

Open vonbearshark opened 7 years ago

vonbearshark commented 7 years ago

We need to distinguish the pins based on the data coming in. We need to have at least separate icons/colors for the city 311 and police data, for now. But we also need icons for the campus police data, fire data, health and safety restaurant inspection data, etc.

brlodi commented 7 years ago

In the short term, thoughts on pin color? I'd color code as follows:

We should be able to do standard pins in straight CSS, unless people feel strongly about generating raster image assets for it?

vonbearshark commented 7 years ago

Those work for me. Just need to make sure it matches up to whatever we use for #37. I think image icons would be a neat feature to have, but we can add them in later if someone gets the energy.

For posterity, here's how we'll implement the icons in the future: http://leafletjs.com/examples/custom-icons/.

brlodi commented 7 years ago

So preferring L.icon to L.divIcon?

vonbearshark commented 7 years ago

It might be simpler, but we can cross that bridge when we revisit it, too. Docs on divIcon for future: http://leafletjs.com/reference.html#divicon

brlodi commented 7 years ago

With regard to color-blindness support, my thinking was to have iconography associated with the pins in addition to color, at least as a long-term. Something like this, but not thrown together in 2 minutes (the 311 numerals don't work at small scale).

artboard 1 2x artboard 2 2x
vonbearshark commented 7 years ago

Those would be dope for now

brlodi commented 7 years ago

@vonbearshark could you assign me to this issue? I'm working on at least some basic flat-ui icons. Speaking of the icons, should I create a map-pins directory in the root or nest it within an images directory? Also, the sources file for these icons is in Illustrator. It's not a huge file but it's definitely a binary file. Should I commit it?

vonbearshark commented 7 years ago

For sure! Thanks, @brlodi! Let's nest it in an assets dir. I think we should keep them out of the git path for now. Maybe we can put the long-term assets' source files in version control, but I think we can get away without it now.

Edit: looks like I can't assign you--could you join the PittCSC org as a member?

brlodi commented 7 years ago

@vonbearshark You'd need to invite me. There's no option for non-members to request membership

vonbearshark commented 7 years ago

Of course there's not. That would be simple. Just sent you an inv

vonbearshark commented 7 years ago

We should delete assets while we're at it

brlodi commented 7 years ago

Should be auto-removed once the files in map-pins are gone, no?

vonbearshark commented 7 years ago

Yeah, that's what I mean