pittcsc / PittAPI

An API to easily get data from the University of Pittsburgh
https://pittapi.pittcsc.org
GNU General Public License v2.0
105 stars 30 forks source link

Non-mocked tests should be mocked #166

Open tianyizheng02 opened 1 month ago

tianyizheng02 commented 1 month ago

See my comment in #165

Tests for certain modules are failing with RecursionError in #165 and other PRs. I suspect that this is because tests in lab_test.py, library_test.py, and people_test.py call their module functions directly (thereby making real HTTP requests) instead of mocking their inputs, which is done for other modules' tests.

Test files to be rewritten: