search

pittcsc / PittAPI

An API to easily get data from the University of Pittsburgh
https://pittapi.pittcsc.org
GNU General Public License v2.0
108 stars 33 forks source link

Rewrite library module tests to use mocked inputs #169

Closed tianyizheng02 closed 4 months ago

tianyizheng02 commented 4 months ago

Contributes to #166

Rewrite tests/library_test.py to use mocked HTTP requests instead of calling module functions directly and making real HTTP requests (see #166). I deleted the tests for the library bookmark functions, since the code makes it clear that the new library API doesn't support bookmarks anyway. I ran pytest locally, and there appear to be no more errors with the library tests.

I also fixed a heretofore unnoticed bug in the library URL, where the URL accidentally contains newline characters due to a triple-quoted string being used instead of a single- or double-quoted string.

tianyizheng02 commented 4 months ago

All tests pass even after I reenabled the library module tests for GitHub.