Open tianyizheng02 opened 2 weeks ago
@nij-patel, you were the one who did most of the work in upgrading the repo to Python 3.12, and @FishOfPitt116, you were the one who updated the versions for coverage
and pytest-cov
, so I'd appreciate it if you two could take a look at my TODOs.
As a follow-up to #176, I want to clean up the dependencies listed in the Pipfile and requirements.txt. Some listed dependencies are no longer used and should be deleted, while others are purely dev dependencies (i.e., used by us for development purposes and not actually required by PittAPI).
I'm opening an issue for this because there are some dependencies that I'm not entirely sure of and I need help figuring out what to do about those ones; I've marked such dependencies with TODO.
KEY:
[dev-packages]
in the PipfileREMOVE: Not actually used as a dependency, marking for deletion
These are the dependencies currently listed in the Pipfile:
beautifulsoup4 = "*"
: REMOVErequests
and other packages.coverage = "==7.4.3"
:TODO,DEVRe: 8d9ab9331a6a8f8c2f67d54cf34275b711f75c95, is there any reason why we must have v7.4.3?It should be fine to use the newest version.requests = "*"
responses = "*"
grequests = "*"
lxml = "*"
: REMOVElxml_html_clean
: we only hadlxml
because we needed it as an optional dependency ofrequests-html
, but the required functionality has been broken off into a separate package. This is what currently happens if you try to run the tests inpeople_test.py
:nose = "*"
: REMOVEnose
withpytest
in #144.nose-cov = "*"
: REMOVEnose
nose-timer = "*"
: REMOVEnose
typing = "*"
virtualenv = "*"
:TODOREMOVEI don't think we directly use this for anything; can someone confirm?Not used, should be safe to remove.black = "*"
: DEVsphinx = "*"
: TODOrequests-html = "*"
parse = "*"
: REMOVEparse
anywhere in the repo, and I think it was phased out along with BeautifulSoup.pre-commit = "*"
: DEVpytest = "*"
: DEVpytest-cov = "==4.1.0"
:TODO,DEVRe: 8d9ab9331a6a8f8c2f67d54cf34275b711f75c95, is there any reason why we must have v4.1.0?It should be fine to use the newest version.pytest-xdist = "*"
: TODOpytest
plugin allows for testing using multiple cores, but we never use it. Should we simply remove this dependency? Or should we actually use it by using it in our GitHub Actions workflows?flake8 = "*"
: DEV