pittcsc / PittAPI

An API to easily get data from the University of Pittsburgh

https://pittapi.pittcsc.org

GNU General Public License v2.0

108 stars 33 forks source link

Making Textbook APIs tests more hermetic #73

Closed azharichenko closed 6 years ago

azharichenko commented 7 years ago

Objective

Making testing more hermetic so that testing is consistent and relies less on servers working. #50

Changes to Tests

Globally

License information has been dropped from all test files and textbook API
Dropped timeout-decorator from requirements as it's no longer being used or needed
Currently, all tests are silenced
Added typing library to requirements for backwards

Textbook

Fixed issue with departments and responses in get_textbooks getting zipped in incorrect order
No longer fetches codes directly from the internet (will add feature later to allow us to convert from Pitt terms to textbook terms since they differ)
Added term validation which apparently was implemented before

Course

Added better method to check for correct terms, though new improved check coming soon since the term code makes sense how it's structured

Dining

Fixed issue with NameError with List