Added most type signatures

pittcsc / PittAPI

An API to easily get data from the University of Pittsburgh

https://pittapi.pittcsc.org

GNU General Public License v2.0

108 stars 33 forks source link

Added most type signatures #76

Closed Doomki closed 6 years ago

Doomki commented 7 years ago

Still to be done: Not completely sure what everything in library.py does, will look into it soon

RitwikGupta commented 7 years ago

Any reason why you closed this PR?

Doomki commented 7 years ago

Travis says some tests are failing, but I'm not able to run the tests on my laptop without getting a stack overflow. Should I just resubmit the pull request? Otherwise I will look into it tomorrow.

RitwikGupta commented 6 years ago

The build system currently has some bad tests, we have a PR working on that! But yes, please resubmit the PR so I can review and merge it.

Doomki commented 6 years ago

Ok, I reopened it. Mypy doesn't give errors for any files, so the signatures are probably ok.