search

pittmesh / ip-calculator

A browser-based calculator for determining PittMesh IP addresses
http://www.pittmesh.net/ipcalc
1 stars 0 forks source link

Avoid collisions https://github.com/pittmesh/ip-calculator/issues/25 #26

Closed jasonkhanlar closed 8 years ago

colindean commented 8 years ago

I'm a little concerned with the unhandled return values, so I'm going to hold off on merging it until you've clarified those.

Protagonistics commented 8 years ago

Colin, I'm not certain I'm following your reasoning? This seems to solve the collision problem. On Jun 16, 2016 1:24 AM, "Colin Dean" notifications@github.com wrote:

I'm a little concerned with the unhandled return values, so I'm going to hold off on merging it until you've clarified those.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pittmesh/ip-calculator/pull/26#issuecomment-226391098, or mute the thread https://github.com/notifications/unsubscribe/ABuiCEsqGZjExLdNpr5RXqec1hYrIvfMks5qMN3ygaJpZM4I2yQK .

colindean commented 8 years ago

Yes, but it’s not clear how. 

Protagonistics commented 8 years ago

Darn right. The script works! Are there collisions? It seems it works. Let's talk about it if it seems problematic. On Jun 16, 2016 1:38 AM, "Colin Dean" notifications@github.com wrote:

Yes, but it’s not clear how.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/pittmesh/ip-calculator/pull/26#issuecomment-226392794, or mute the thread https://github.com/notifications/unsubscribe/ABuiCH44Hhq2XnM9ixVmPT_axCo0G9wLks5qMOFmgaJpZM4I2yQK .

colindean commented 8 years ago

@Protagonistics, there are potential issues that @jasonkhanlar needs to address before we can merge this. Five to ten minutes of work probably.

Protagonistics commented 8 years ago

What are the potential issues? I'm guessing you mean collisions? On Jun 16, 2016 10:54 PM, "Colin Dean" notifications@github.com wrote:

@Protagonistics https://github.com/Protagonistics, there are potential issues that @jasonkhanlar https://github.com/jasonkhanlar needs to address before we can merge this. Five to ten minutes of work probably.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pittmesh/ip-calculator/pull/26#issuecomment-226668497, or mute the thread https://github.com/notifications/unsubscribe/ABuiCKM0sdTwpssNsRxQQ1BSkP_5_Fl6ks5qMgxzgaJpZM4I2yQK .

colindean commented 8 years ago

Excellent refactoring!