search

pityka / lamp

deep learning and scientific computing framework with native CPU and GPU backend for the Scala programming language
https://pityka.github.io/lamp/
Other
29 stars 4 forks source link

Codebase would not longer compile with Scala 3.6 #478

Open WojciechMazur opened 2 months ago

WojciechMazur commented 2 months ago

When running weekly Scala 3 Open Community Build we've found out that this project started to fail - build logs.

We've reproduced and minimized the issue, however, but it was decided that it now works as expected https://github.com/scala/scala3/issues/21632#issuecomment-2368683664

The workaround to fix this issue is introducing local variables before calling unflift on Module instances.

Sidenote: Scala 3 OpenCB does compile the codebase twice for this project: 1 run using Scala 3.4.2 usues -rewrite, -source:3.4-migration mode to adapt the codebase, eg. rewrite with to &. That's why the reproducer uses a slightly different syntax

pityka commented 2 months ago

Thanks a lot for all of this! I will try to make it compile under the latest nightly builds of the compiler.