search

piuccio / cowsay

cowsay is a configurable talking cow
Other
1.14k stars 160 forks source link

Fix #13: Add option -r to select a random cow #30

Closed doug2k1 closed 6 years ago

doug2k1 commented 7 years ago

Added -r option just for CLI. I could try adding for the browsers also, if that's desirable.

doug2k1 commented 7 years ago

Sure! I'll look into it tonight.

doug2k1 commented 7 years ago

Hi, I fixed the indentation.

Still working on the browser version. I'm not sure if it's possible without braking the tree-shaking possibility, since I'll have to import all cows to randomize between them.

piuccio commented 7 years ago

That's true, let's leave it for now, it's quite easy to implement random cows client side

On Thu, 26 Oct 2017, 21:49 Douglas Matoso, notifications@github.com wrote:

Hi, I fixed the indentation.

Still working on the browser version. I'm not sure if it's possible without braking the tree-shaking possibility, since I'll have to import all cows to randomize between them.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/piuccio/cowsay/pull/30#issuecomment-339654914, or mute the thread https://github.com/notifications/unsubscribe-auth/AAphXJHqraQXV-6jWS8fTWnOUgDKKeW4ks5swH_TgaJpZM4QE4rz .

piuccio commented 6 years ago

Sorry I completely forgot about this, released in 1.3.0