Closed carlschroedl closed 5 years ago
Can we simplify the user experience by splitting this into two pages?
Changes to the registration pages would potentially break the selenium-driven create_users
function in tests.py. I notice our build doesn't use this functionality by default; instead it uses the TravisSeeder class to achieve the same results. If breaking changes to the registration pages occur, what should we do with the create_users
Python function? Fix it? Delete it?
I like the suggestion about splitting into two pages (or at least make it feel like two different pages with JS).
I'm fine getting rid of create_users, unless you think it's useful for testing purposes.
I added create_users because I didn't know about the Laravel seeding stuff, and I wanted some way to create users automatically. @olivernybroe later added the seeding, which I think is cleaner.
Personally, I would delete create_users for now, and add it back later only if we want to have selenium tests of registration.
Thanks for the helpful context and for weighing in on the suggestion!
You can also do selenium testing directly in Laravel, think it's called Laravel Dusk
As grandma I want to register so that I can see what all the hullabaloo is about this "Ranked Pairs" voting the whippersnappers are talking about.