search

pivot-libre / tideman

Implementation of the Tideman ranked pairs algorithm
Apache License 2.0
9 stars 3 forks source link

Implement winning votes #79

Closed carlschroedl closed 6 years ago

carlschroedl commented 6 years ago

Tis isn't done, but I thought it would be helpful to get a peek at it Removed filtering from PariList becase that is accomplished in the PairRegistry now. One broken test. Moved indifference incrementing from abstract class to WinningVoteRegistrar because indifference is only changed when working with winning votes. Tested WinningVoteRegistrar. Changed Pair->indifference initial value from null to 0. Made test more comprehensive Documentation improvements

coveralls commented 6 years ago

Coverage Status

Coverage increased (+8.3%) to 98.765% when pulling 2c59c8c0f826d50fa00408f57f1e8636b03893d5 on carlschroedl:implementWinningVotes into c9bdc9a751c3fb93e40822942b11949870fd8bc7 on pivot-libre:0.x.

carlschroedl commented 6 years ago

I looked at the problems Codacy identified. I choose not to fix them.

carlschroedl commented 6 years ago

This isn't a full implementation of winning votes. It will be fully implemented once the WinningVotesRegistrar classs gets used in RankedPairsCalculator and we add some RankedPairsCalculatorTests that describe the expected winning votes behavior. Nevertheless, this is a decently-large set of changes so, to avoid merge conflicts, I want to merge before Tyler has a chance to lean into this stuff starting next week.