search

pivot-libre / tideman

Implementation of the Tideman ranked pairs algorithm
Apache License 2.0
9 stars 3 forks source link

Final ranking tests#52 #92

Closed carlschroedl closed 6 years ago

carlschroedl commented 6 years ago

This PR addresses #52. This adds one final ranking test from the Tideman Zavist 1987 paper and four of the five tests from the test scenario spreadsheet.

The remaining test in the spreadsheet has a lot of edge ties so I'm guessing it will be harder to debug. I won't have much time to work on this the next few days. In the mean time it would be good to get these other tests merged so that they can run against other functionality that might be incorporated like any bug fixes that arise from the random graph generation.

This pull request builds off of commits in #91. It will be easier to review once #91 is merged.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+2.5%) to 84.142% when pulling a1c63eea3135b5c234d1a9c58adbf00b5fb64812 on carlschroedl:finalRankingTests#52 into 11ca8836b9378b6b95568c5b7c965531a5c58ef8 on pivot-libre:0.x.

carlschroedl commented 6 years ago

All of the issues Codacy identified relate to things added in the other dependent pull request.