search

pivotal-cf-experimental / ops_manager_ui_drivers

DEPRECATED as of OM 1.11; don't even think about using this repo
Other
4 stars 4 forks source link

Disable ICMP checks #18

Closed cgfrost closed 8 years ago

cgfrost commented 8 years ago

It is not possible to configure ops manager to have ICMP checks disabled. The field name is icmp_checks_enabled but it isn't used in the code. For example, in https://github.com/pivotal-cf-experimental/ops_manager_ui_drivers/blob/master/lib/ops_manager_ui_drivers/version17/ops_manager_director.rb#L47 I would expect to see some code for applying the icmp_checks_enabled value. Same for the other versions as well. This feature is needed in the Spring Cloud Services team to help us automate more of our CI.

cf-gitbot commented 8 years ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

ctaymor commented 8 years ago

I'll talk with product to prioritize this work, it doesn't seem very difficult. Alternatively, we do accept pull requests.

ctaymor commented 8 years ago

To be clear, are you using ops_manager_ui_drivers directly? The OpsManager team doesn't control OpsMgr, if that's what you're using.

cgfrost commented 8 years ago

We are using OpsMgr but we will either by pass it or get OpsMgr support for ICMP added.

drich10 commented 8 years ago

Added as a part of the https://github.com/pivotal-cf-experimental/ops_manager_ui_drivers/tree/v2.24.0 release

cgfrost commented 8 years ago

Awesome stuff, thank you.