search

pivotal-cf / azure-blobstore-resource

A concourse resource to interact with the azure blob service.
MIT License
16 stars 15 forks source link

Don't return blobs which are still being copied #22

Closed rkoster closed 5 years ago

rkoster commented 5 years ago

This PR fixes a bug where a new version would trigger while a blob is still being copied. This would result in jobs which depend on a new version of a blob to fail with messages like:

Deployment failed. Correlation ID: 185a66f1-b392-47c5-8c48-cc5c3de05dbe. {
  "error": {
    "code": "InvalidParameter",
    "message": "Cannot import source blob ... since it has not been completely copied yet. Copy status of the blob is CopyPending.",
    "target": "disks"
  }
}

I though about making this optional, but could not think of a use-case where you would be interested in a partially uploaded blob.

rkoster commented 5 years ago

@christianang are you still involved with this project? and if not do you know who has taken over?

christianang commented 5 years ago

Hey @rkoster I'm still maintaining this repo, sorry I have been slow to respond. The PR looks good to me from a quick glance. I'll work on merging it and cutting a new release in the next couple days. Thanks.

rkoster commented 5 years ago

Thanks!

christianang commented 5 years ago

Cut a new image with the change.

rkoster commented 5 years ago

Thanks!