pivotal-cf / bbr-pcf-pipeline-tasks

Collection of Concourse tasks for backing up a Tanzu Application Service (TAS) installation using BOSH Backup and Restore (BBR)
Apache License 2.0
37 stars 63 forks source link

Consider versioning these tasks #34

Closed aegershman closed 5 years ago

aegershman commented 5 years ago

In order to allow consumers to consume this repository directly as a Concourse resource without being broken when non-passive changes are made, have you considered versioning these tasks?

Or if the tasks aren't going to be versioned, should these tasks be treated strictly as "reference tasks" not designed for direct consumption?

Surely there is going to come a day when these tasks will no longer be backwards compatible with every version of PAS/Opsmgr/PKS/etc. Perhaps it would be too much management overhead to maintain all different task compatibilities for different versions of products; case in point, the pcf-pipelines project has to maintain all these compatibility matrices and such. But then again, without version pinning, people using different product combinations will eventually be broken; naming conventions will eventually change (case in point, ERT is now PAS), etc.

cf-gitbot commented 5 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/161514814

The labels on this github issue will be updated when the story is started.

ChunyiLyu commented 5 years ago

Hi @aegershman,

Thanks for the input! That is a very good point. However, maintaining different versions of each tasks would require more effort/costs at testing. I think for now, we will keep having one stable version of all tasks, until it gets costly to maintain backwards compatibility.

Cheers, Chunyi

aegershman commented 5 years ago

I understand 👍 ... Still, I'm going to kvetch a little more, then I'll drop it:

The reason I make a fuss about it is because this is basically the only maintained BBR automation out there (maybe I'm looking in wrong places?). Lots of people/companies have open sourced their concourse tasks/resources for app dev, platform automation, metrics collections, etc., and so there are many ideas to draw from and expand upon. It appears this repository is the only guidance out there for BBR automation, and it's a little beholden to it's existing self due to naming conventions and such.

with all this said... I don't mean to sound pushy or too critical; I respect your decisions, I trust you all enough to have this code running in our prod foundations, and I appreciate the work you all are doing.

glestaris commented 5 years ago

Hey @aegershman, we appreciate the feedback. Let me add a bit more colour to @ChunyiLyu's response.

The aim of this repo is to help PCF platform engineers automate the taking of a full backup of a PCF foundation. To this extent, your engagement with this project is highly appreciated as it means that you are finding value in this work.

In staying true to our aim, we are currently seeking ways to be involved in other, similar, efforts within PCF such as the successor of PCF Pipelines. That's not to say that this repo will be deprecated any time soon, but we are examining ways to help platform engineers automate things (e.g.: backups and upgrades) in a unified and consistent way. Hence, while we are figuring out what the future of PCF Pipelines will look like, we are reducing our investment in this project.

Nevertheless, we are still interested in the use cases and problems with this project as this would be amazing input for the future shape and form of PCF Pipelines and the BBR Backup Pipeline tasks. Would you be interested in spending some time with us to describe how you use the BBR Pipeline tasks and what are the limitations/issues you see?