search

pivotal-cf / bookbinder

A command line utility for stitching modular Markdown docs into into a unified, hostable web-app.
Apache License 2.0
45 stars 46 forks source link

Support fuzzy match code snippet #129

Closed jtarchie closed 4 years ago

jtarchie commented 6 years ago

support fuzzy matching of directories when using non master directory structure

The current workflow for yield_for_code_snippet assumes all snippets are always in the master branch. The lookup path for the snippet directory would be (in order):

When we moved from master to develop/release pattern, our document generation starting failing in the Concourse pipeline. This is because our input name was platform-automation-develop instead of the assumed platform-automation-master as noted above.

This change supports the fact that inputs (from the generated pipeline), do not support that format. It will perform precedence lookup, as above, and then do a best match for a directory. This means that our workflow of develop/release will be supported and we do not break existing master patterns. [#161320648]

cfdreddbot commented 6 years ago

Hey jtarchie!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.