search

pivotal-cf / brokerapi

A Go package for implementing the V2 Open Service Broker API
Apache License 2.0
85 stars 71 forks source link

Missing metadata field in ProvisionedServiceSpec #128

Closed jasiu001 closed 3 years ago

jasiu001 commented 3 years ago

Hi,

According to OSB API, we should be allowed to return the metadata field in a provisioning response. Do you plan to update ProvisionedServiceSpec struct in the near future?

If no, then we can make a contribution, but to be honest, we really need this fast so my second question will be: there is a chance all processes from your side about the review and merge will be quick?

cf-gitbot commented 3 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/176071626

The labels on this github issue will be updated when the story is started.

FelisiaM commented 3 years ago

Hi @jasiu001

This is a property introduced in OSBAPI 2.16 and we haven't started working on that yet. We are not doing much active development here at the movement but we would be happy to review your PR and merge it asap 🙂

As a side note, it would be interesting to know what is your use case for returning metadata on provision and which platform would be using that?

Thanks, Felisia

jasiu001 commented 3 years ago

Hi @FelisiaM

That is great, I made PR with implementation.

We use your library in our open-source Kyma project, to be more specific in the system which installs clusters with Kyma. External services trigger provisioning using OSB API and your library is really helpful to handle this :)

FelisiaM commented 3 years ago

Thank you for your contribution @jasiu001

I have now merged the PR and released version 7.5.0 with the change