pivotal-cf / brokerapi

A Go package for implementing the V2 Open Service Broker API
Apache License 2.0
85 stars 71 forks source link

Support for Binding rotation #200

Closed reborn1867 closed 2 years ago

reborn1867 commented 2 years ago

I would like to implement service binding rotation in my service broker while I cannot find the corresponding function in interface ServiceBroker. And for func Bind(), there's no predecessor_binding_id field in BindDetails, which is required for binding rotation according to the OSB specification. I'm wondering if there's any on-going task about this topic?

cf-gitbot commented 2 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/181213486

The labels on this github issue will be updated when the story is started.

pivotal-marcela-campo commented 2 years ago

Hi @reborn1867, there are no plans to implement binding rotation at the moment. The OSB spec has predecessor_binding_id in its master branch only meaning it hasn't yet been released in any version.

You could submit a PR and we would be happy to consider merging it to brokerapi regardless. It' issworth mentioning though that including it in brokerapi won't be of much value if it doesn't get implemented in the actual platform (e.g cloudfoundry). Your broker would be capable of receiving and act on this property but the platform wouldn't be sending it at all .

Hope that makes sense

reborn1867 commented 2 years ago

Thanks a lot for the clarification, and I would love to submit my PR if the binding rotation is actually released.