search

pivotal-cf / docs-build-service

Documentation to help with installing and using Build Service
Apache License 2.0
6 stars 28 forks source link

Add a guide on how to add a buildpack to a builder #325

Closed yaelharel closed 1 year ago

yaelharel commented 1 year ago

Fixes https://github.com/pivotal/build-service/issues/869

cf-gitbot commented 1 year ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

kcoriordan commented 1 year ago

@yaelharel - branch 1.10 is the current production branch for latest version 1.10, should this be cherry picked to that. I can do the cherry-picking, just need to confirm with you. thanks

kcoriordan commented 1 year ago

@chenbh - can you take a look again now at the structure and see if it makes sense: https://docs-staging.vmware.com/en/Tanzu-Build-Service/1.11/vmware-tanzu-build-service/add-buildpack-to-builder.html

Also the positioning in the table of contents, I added it under Managing Cluster Stores - but I think maybe that's not the best place?

Also for cherry-picking, I will cherry-pick this back to 1.10 once you confirm the content is all complete and correct.

thanks

chenbh commented 1 year ago

can you take a look again now at the structure and see if it makes sense:

Looks good, one minor spelling is that As should be lower case in the prereqs Package a buildpack As descibed here...

Also the positioning in the table of contents, I added it under Managing Cluster Stores - but I think maybe that's not the best place?

Maybe we can name this page "Managing Buildpacks" and slot it between "Managing Builders" and "Managing Custom Stacks"? Although "Adding Buildpacks to Builders" is a lot more descriptive and have better glance value.

kcoriordan commented 1 year ago

Thanks very much @chenbh I've cherry-picked to 1.10. I left the topic title as is, the more descriptive titles are probably better for SEO.

https://docs-staging.vmware.com/en/Tanzu-Build-Service/1.11/vmware-tanzu-build-service/add-buildpack-to-builder.html https://docs-staging.vmware.com/en/Tanzu-Build-Service/1.10/vmware-tanzu-build-service/add-buildpack-to-builder.html