search

pivotal-cf / docs-build-service

Documentation to help with installing and using Build Service
Apache License 2.0
6 stars 28 forks source link

Update installing-tap-profile.html.md.erb #340

Closed mvalliath closed 1 year ago

cf-gitbot commented 1 year ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

RichardJJG commented 1 year ago

We received your PR after the doc freeze date. We are currently working on release tasks, and we will review your PR as soon as we are able. Unfortunately, this may mean that your PR content will not be published until after the release. Going forward, to ensure that your PR changes are published on release day, please submit such PRs no later than 23:59 UTC-8 on the doc freeze date.

mvalliath commented 1 year ago

Hi @RichardJJG!

Is this new policy? We've always updated the standalone TBS docs as we go. We try to get in our PRs to the docs-tap repo before docs freeze dates, but never assumed changes to the standalone TBS docs were subject to the TAP docs freeze dates, because standalone TBS is separate product from TAP (it GA'd a couple years before TAP did).

RichardJJG commented 1 year ago

Hi, @mvalliath, I was on Interrupt duty at the time and assumed docs-build-service was tied to the latest TAP patch releases (most smaller docs repos associated with the TAP core docs publish at exactly the same cadence, and it was safer than assuming otherwise at the time).

You're right that, if docs-build-service is not about to be published, then these docs are not frozen. I merged your PR within 2 hours of saying I might not be able to -- I was keen to set expectations =P