pivotal-cf / java-cfenv

Apache License 2.0
95 stars 59 forks source link

Remove spring boot dependency from core project #194

Closed shanman190 closed 1 year ago

shanman190 commented 2 years ago

So when the java-cfenv library migrated to Gradle, the project began to use a Gradle platform for version alignment. The chosen platform was the spring-boot-dependencies BOM. While the java-cfenv-{version}.pom does not include any <dependencyManagement> section, the java-cfenv-{version}.module includes the platform constraint. When the library is used with a Spring project that is not aligned with the spring-boot-dependencies BOM platform that the project is using this results in Gradle changing the project's dependencies through it's dependency constraint in the module metadata.

The associated changes on this PR, removes the Spring Boot Dependencies BOM and instead uses the aligned Jackson BOM that is used for the current Spring Boot version. Then then changes the dependency constraint such that it will now only effect the Jackson modules, instead of a much, much larger set of dependencies.

anthonydahanne commented 1 year ago

Fixed with https://github.com/pivotal-cf/java-cfenv/commit/9f218da249027566923b400d7cbeed42049ee9b3#diff-3246c132b2de61117694bcb98cab0fcc7f3f4bf27defe029227fb63cb3327e51L9