pivotal-cf / java-cfenv

Apache License 2.0
91 stars 56 forks source link

3.0.0 Snapshot looks like it has a bug configuring SSL when using PCF Redis service tile #218

Open ahall-vmware opened 11 months ago

ahall-vmware commented 11 months ago

The documentation for SSL enabling uses the property spring.data.redis.ssl.enabled, whereas the RedisCfEnvProcessor is using .ssl without the .enabled piece.

https://github.com/pivotal-cf/java-cfenv/blob/a28f4573079fb58a8c897077ce9ac30623827da6/java-cfenv-boot/src/main/java/io/pivotal/cfenv/spring/boot/RedisCfEnvProcessor.java#L61

and

https://github.com/pivotal-cf/java-cfenv/blob/a28f4573079fb58a8c897077ce9ac30623827da6/java-cfenv-boot/src/main/java/io/pivotal/cfenv/spring/boot/RedisCfEnvProcessor.java#L71 This results in errors like:

Update your application's configuration 
Action:
Reason: org.springframework.core.convert.ConverterNotFoundException: No converter found capable of converting from type [java.lang.String] to type [org.springframework.boot.autoconfigure.data.redis.RedisProperties$Ssl]

Failed to bind properties under 'spring.data.redis.ssl' to org.springframework.boot.autoconfigure.data.redis.RedisProperties$Ssl:
ilker-yk commented 4 months ago

Hi, any progress on this? I had the same issue.

image