pivotal-cf / java-cfenv

Apache License 2.0
95 stars 59 forks source link

Configure cfenv.service.<serviceName>.enabled=false in application.yaml #231

Closed Marty850 closed 10 months ago

Marty850 commented 1 year ago

Is your feature request related to a problem? Please describe.

We noticed that java-cfenv changes special characters in the password of our jdbc connectionString. Thats why we would like to disable cfenv for that service.

We found the parameter cfenv.service.<serviceName>.enabled=false that is documented here but it is not possible to configure at in a yaml file. Only application.properties works.

Describe the solution you'd like

I would like to have the possibility to disable java-cfenv for a service by using both configuration methods (application.yaml and application.properties)

Describe alternatives you've considered

No response

Additional context

No response

Marty850 commented 1 year ago

I just noticed that it is possible to configure it in application.yaml as well by putting it in the first line and change the = to a :

cfenv.service.<serviceName>.enabled: false

Maybe it's enough to add a hint to the documentation.

anthonydahanne commented 11 months ago

Hello!

We noticed that java-cfenv changes special characters in the password of our jdbc connectionString.

Just to be sure, it was happening with a DB2 connection string?

Maybe it's enough to add a hint to the documentation.

Yes, that makes sense

Marty850 commented 11 months ago

Hi Anthony, yes it is a DB2 connection string.

cf-env does a url encoding and the db2 driver cannot deal with that. So cf-env is currently not usable for db2 connections unless you use cfenv.service.<serviceName>.enabled=false as a workaround.

Marty850 commented 11 months ago

@anthonydahanne I noticed your Fix for the URL encoding issue. Can you say when this will be released?

anthonydahanne commented 10 months ago

today! 3.1.3 is available on central!

https://github.com/pivotal-cf/java-cfenv/releases/tag/v3.1.3