search

pivotal-cf / java-cfenv

Apache License 2.0
95 stars 59 forks source link

Support for R2DBC connections in DataSource processor. #262

Closed gm2552 closed 1 month ago

gm2552 commented 6 months ago

java-cfenv-boot currently does not support setting R2DBC properties creating the necessity of developers to process VCAP_SERVICES themselves when they wish to autoconfigure R2DBC connections.

This enhancement mimics the Spring Cloud Bindings library in that it incorporates setting R2DBC properties (spring.r2dbc.*) along side DataSource properties (spring.datasource.*) .

anthonydahanne commented 1 month ago

@gm2552 , after merging #271 , we now have proper mariadb support

after rebasing your PR, I'll remove the mariadb support from your PR

anthonydahanne commented 1 month ago

ouch, once again I broke the PR pushing to your main.

I guess contributors should always create a new branch than main, so that I don't accidentally delete their PR when I force push to their branch

anthonydahanne commented 1 month ago

replicated in #272