use basic auth for all request to artifactory if credentials are defined

pivotal-cf / kiln

Kiln helps you maintain product tiles for VMware Tanzu Operations Manager.

Apache License 2.0

30 stars 20 forks source link

use basic auth for all request to artifactory if credentials are defined #491

Closed dlinsley closed 6 months ago

dlinsley commented 7 months ago

Resolves https://github.com/pivotal-cf/kiln/issues/474

verified local tests covers change.

Tested following subcommands against an artifactory that required authentication:

find-release-version
update-stemcell
update-release

cf-gitbot commented 7 months ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

dlinsley commented 7 months ago

Also confirmed this is functional for :

bake with & without --final
re-bake

With an artifactory requiring authentication