pivotal-cf / om

General command line utility for working with VMware Tanzu Operations Manager
Apache License 2.0
135 stars 104 forks source link

fix: handle non-zero return code from Azure CLI #635

Closed blgm closed 6 months ago

blgm commented 7 months ago

Resolves #633

When running "om vm-lifecycle create-vm" on Azure, a problem has recently occurred where querying a blob status using "az storage blob show" has started to exit with a non-zero code and error "There is currently a pending copy operation". Because of the error, the command terminates. It's likely that this is because of a change in the backend Azure API. As we are trying to determine whether the copy operation has finished, it's safe to ignore this error and continue polling.

cf-gitbot commented 7 months ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

wayneadams commented 6 months ago

Merging after running VMManagers Suite tests locally:

root@e5e63a908f73:/workspace/om/vmlifecycle/vmmanagers# ginkgo
Running Suite: VMManagers Suite
===============================
Random Seed: 1712855812
Will run 224 of 224 specs

••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 224 of 224 Specs in 0.960 seconds
SUCCESS! -- 224 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

Ginkgo ran 1 suite in 6.475538713s
Test Suite Passed