search

pivotal-cf / pivnet-resource

Concourse Resource to interact with the Tanzu Network API V2 interface.
Apache License 2.0
30 stars 36 forks source link

PUT not usable for externals? #134

Open mmanciop opened 4 years ago

mmanciop commented 4 years ago

I am automatic the creation of a tile release on VMware Tanzu network, and while the put step works, the following (unavoidable?) get step fails because apparently I need to accept the EULA for for my very own release I just created.

2020/09/17 08:09:00 PivNet Resource version: 2.0.1
2020/09/17 08:09:00 Creating download directory: /tmp/build/get
2020/09/17 08:09:00 Getting release for product slug: 'instana-microservices-application-monitoring' and product version: '1.186.0'
2020/09/17 08:09:01 Accepting EULA for release with ID: 743234
ERROR: user with email 'michele.mancioppi@instana.com' has not accepted the current EULA for release with 'id'=743234. Please manually accept the EULA via this URL: https://network.pivotal.io/products/313/releases/743234/eulas/193

Issue #74 seems to imply that this is expected behaviour, however Kafka-esque and frustrating (days of work sank into getting this far :D) it is.

I have looked for ways to ignore the error, but since the get is implicit, I could not find a way to ignore that error, without also ignoring errors on put.

Any ideas?

mmanciop commented 4 years ago

In the README.md I found:

You will be required to accept a EULA for any product you're downloading for the first time, as well as if the terms and conditions associated with the product change.

I understand why it is like this generally in terms of legal implications, but I cannot believe that someone considered the use-case of "I am uploading my own release" and said "Yeah, you gotta accept that EULA too!" :D

mmanciop commented 4 years ago

It frankly would be even fine with me to have a way to skip the implicit get, the put succeeding is enough indication of success.

jtarchie commented 3 years ago

The get step is implicitly done be Concourse, the resource has no control over that.

mmanciop commented 3 years ago

Would it be possible to a "accept-eula" logic to the put or a "skip-eula" to get (if Pivnet allows)?