Pivnet-resource should optionally trigger on version changes only

pivotal-cf / pivnet-resource

Concourse Resource to interact with the Tanzu Network API V2 interface.

Apache License 2.0

30 stars 36 forks source link

Pivnet-resource should optionally trigger on version changes only #90

Closed jacknewberry closed 5 years ago

jacknewberry commented 6 years ago

Symptom: We use pivnet-resource in the PCF Redis team to trigger our pipelines when new stemcell patches are released.

We use tag: latest-final of pivnet-resource from docker hub.

Current Behaviour: Multiple changes to source metadata causes our pipelines to run multiple times with the same stemcell. The last stemcell (3445.28) triggered 5 times across several hours.

We suspect that in most cases the pivnet resource should not trigger on changes to metadata. We want the resource to trigger only on changes to the minor version.

Suggestion:

Add an 'ignore_metadata_changes' flag to the source configuration. This would allow teams that wish to check metadata to continue to do so, while improving the experience for teams interested in actual releases.

cc: @mrosecrance

cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/155524717

The labels on this github issue will be updated when the story is started.

tiffjordan commented 6 years ago

Hi @jacknewberry, We are adding a story to our backlog for this feature, but you can also feel free to submit a PR if you'd like this sooner. To confirm, with the 'ignore_metadata_changes' flag, would you like any changes other than file changes to be ignored?

jacknewberry commented 6 years ago

Yes, with ignore_metadata_changes: true, I think any changes that are not file changes should be ignored.

tiffjordan commented 6 years ago

@jacknewberry If you log in without an admin or special access account, does that help resolve the issue as well?

jacknewberry commented 6 years ago

Hi Tiffany,

I think using a user with reduced permissions has fixed this for us. We won't know for certain until a new stemcell is released.

It is a little less than ideal. We now need to maintain separate users to check pivnet, and to upload to pivnet. I'm sure we will manage.

Jack

On Tue, May 15, 2018 at 8:13 PM Tiffany Jordan notifications@github.com wrote:

@jacknewberry https://github.com/jacknewberry If you log in without an admin or special access account, does that help resolve the issue as well?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pivotal-cf/pivnet-resource/issues/90#issuecomment-389280960, or mute the thread https://github.com/notifications/unsubscribe-auth/AAfjQA1f_YUHnr3y1D_66ooJCg5p9H7zks5tyyjPgaJpZM4STq4W .

davewalter commented 6 years ago

Hi @tiffjordan,

We definitely see this when our PMs make changes to our releases once they are public. We've gotten around it by checking the version of the triggering resource against an external file to see if we have already performed the desired action, but it would be nice if we didn't have to do this.

Regards, Dave

pnikonowicz commented 5 years ago

I will bring this to our PM's attention. Closing issue. Marking as wont' fix.

This is not permanent but a reflection of the current status. Please feel free to comment or reopen.