search

pivotal-cf / pivotal-ui

Pivotal's design system & component library
https://styleguide.pivotal.io
MIT License
638 stars 90 forks source link

Unzipping pui-vx.x.x.zip should unzip into a subdirectory #126

Closed utako closed 9 years ago

utako commented 9 years ago

Unzipping a release zip file places all its contents into pwd instead of unzipping into a subdirectory. I think users commonly expect the contents to get unzipped to a subdirectory.

flavorjones commented 9 years ago

I agree, this was also confusing to me when I first used PUI. It's much more common to find packages that create a subdirectory with the version embedded in the name.

scottruitt commented 9 years ago

@utako @flavorjones I'll get this in before our next release, whenever that comes.

pmeskers commented 9 years ago

This should have been addressed a few releases ago -- what release are you noticing this problem with? I've just tried this with v1.4.0 and it worked as I expected:

flavorjones commented 9 years ago

I experienced this behavior when I used pui-v1.3.0. Apologies if it's been addressed in the meantime.

On Wed, Jan 28, 2015 at 9:54 AM, Paul Meskers notifications@github.com wrote:

This should have been addressed a few releases ago -- what release are you noticing this problem with? I've just tried this with v1.4.0 and it worked as I expected:

https://camo.githubusercontent.com/a0990b5cef3265eb8d092f1d5699e10517b9628c/687474703a2f2f672e7265636f726469742e636f2f494539354f69693257312e676966

— Reply to this email directly or view it on GitHub https://github.com/pivotal-cf/pivotal-ui/issues/126#issuecomment-71846931 .

pmeskers commented 9 years ago

I just tried this with pui-v1.3.0 and it still behaved as expected -- if I had to guess, I would say it might depend on how the unizipping is happening. It could be that OS X/Finder is doing some magic on our behalf when we unzip as shown in the .gif above.

¯(ツ)/¯

If anybody has more details, I'm happy to investigate further.

Cheers!

scottruitt commented 9 years ago

1.4 works as expected.

flavorjones commented 9 years ago

@scottruitt and @pmeskers: This is still not working as expected for the 1.4.0 release.

An examination of the zip file shows that there is no common subdirectory for all the contents:

pui-test $ unzip -l ~/Downloads/pui-v1.4.0.zip 
Archive:  /home/miked/Downloads/pui-v1.4.0.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
       24  2015-01-26 10:30   404.html
       45  2015-01-26 10:30   Staticfile
   554548  2015-01-26 10:30   all.html
   167831  2015-01-26 10:30   beta.html
    96430  2015-01-26 10:30   by_product.html
   159355  2015-01-26 10:30   elements.html
    98868  2015-01-26 10:30   forms.html
    31692  2015-01-26 10:30   index.html
    31692  2015-01-26 10:30   intro.html
    85183  2015-01-26 10:30   layout.html
     1036  2015-01-26 10:30   nginx.conf
   196910  2015-01-26 10:30   objects.html
      596  2015-01-26 10:30   pane.html
   633379  2015-01-26 10:30   pivotal-ui-rails.css
  1320595  2015-01-26 10:30   pivotal-ui-react.js
   429284  2015-01-26 10:30   pivotal-ui-react.min.js
   217890  2015-01-26 10:30   pivotal-ui.css
   581800  2015-01-26 10:30   pivotal-ui.js
   176788  2015-01-26 10:30   pivotal-ui.min.css
   182646  2015-01-26 10:30   pivotal-ui.min.js
    38073  2015-01-26 10:30   pui-variables.scss
    53248  2015-01-26 10:30   utilities.html
        0  2015-01-26 10:30   bootstrap-sass/
      141  2015-01-26 10:30   bootstrap-sass/_bootstrap-compass.scss
... snip ...
        0  2015-01-26 10:30   fonts/
    85908  2015-01-26 10:30   fonts/FontAwesome.otf
    56006  2015-01-26 10:30   fonts/fontawesome-webfont.eot
   287526  2015-01-26 10:30   fonts/fontawesome-webfont.svg
   112160  2015-01-26 10:30   fonts/fontawesome-webfont.ttf
... snip ...
        0  2015-01-26 10:30   images/
    34041  2015-01-26 10:30   images/aboutus-hero.jpg
    42805  2015-01-26 10:30   images/console-laptop.png
     1150  2015-01-26 10:30   images/favicon.ico
... snip ...
        0  2015-01-26 10:30   oocss/
     1710  2015-01-26 10:30   oocss/_clearfix-me.scss
... snip ...
        0  2015-01-26 10:30   styleguide/
        0  2015-01-26 10:30   styleguide/gentle_scroll.js
... snip ...
        0  2015-01-26 10:30   syntax-highlighting/
     4152  2015-01-26 10:30   syntax-highlighting/prism-default.css
     1748  2015-01-26 10:30   syntax-highlighting/prism-okaida.css
        0  2015-01-26 10:30   zeroclipboard/
    85612  2015-01-26 10:30   zeroclipboard/ZeroClipboard.js
     6580  2015-01-26 10:30   zeroclipboard/ZeroClipboard.swf
        0  2015-01-26 10:30   bootstrap-sass/bootstrap/
     1545  2015-01-26 10:30   bootstrap-sass/bootstrap/_alerts.scss
     1200  2015-01-26 10:30   bootstrap-sass/bootstrap/_badges.scss
... snip ...
        0  2015-01-26 10:30   bootstrap-sass/bootstrap/mixins/
      263  2015-01-26 10:30   bootstrap-sass/bootstrap/mixins/_alerts.scss
      212  2015-01-26 10:30   bootstrap-sass/bootstrap/mixins/_background-variant.scss
      492  2015-01-26 10:30   bootstrap-sass/bootstrap/mixins/_border-radius.scss
... snip ...
      189  2015-01-26 10:30   bootstrap-sass/bootstrap/mixins/_text-emphasis.scss
      168  2015-01-26 10:30   bootstrap-sass/bootstrap/mixins/_text-overflow.scss
     6598  2015-01-26 10:30   bootstrap-sass/bootstrap/mixins/_vendor-prefixes.scss
---------                     -------
  7769263                     166 files
scottruitt commented 9 years ago

@flavorjones you're running which version of nokogiri?

gpleiss commented 9 years ago

@scottruitt :clap: :100:

atomanyih commented 9 years ago

Hello ghosts of the past, I believe this is working fine now