search

pivotal-cf / spring-cloud-services-connector

Spring Cloud Connectors for Spring Cloud Services on PCF
http://docs.pivotal.io/spring-cloud-services
Apache License 2.0
27 stars 31 forks source link

Compatibility with Spring Cloud Gateway & WebFlux #77

Open habuma opened 6 years ago

habuma commented 6 years ago

Because SC Gateway is based on Spring WebFlux, but our connectors depend on Spring Security for OAuth (S2OAuth), which depends on Spring MVC, it has been found that SCS client apps are not compatible with Spring Cloud Gateway and, more specifically, Spring WebFlux.

Given that the Spring Framework is promoting reactive programming heavily and given that Spring Cloud Gateway is replacing Spring Cloud Netflix Zuul as the gateway of choice, it is likely that SCS customers will want to use WebFlux (either for API purposes or using WebClient instead of RestTemplate...or both). Therefore, we should aim to support WebFlux as an option in SCS client applications.

Note, the incompatibility appears to come from our reliance on S2OAuth for security between clients and the services. And since S2OAuth does not support WebFlux, we may should consider moving toward Spring Security 5's client-side OAuth support, working with the Spring Security team to ensure that our needs are met for client-side applications. Also note that this is largely a starters/connectors issue and there is no anticipated impact to the broker or backing apps.

csterwa commented 5 years ago

@habuma is this now resolved?

gewure commented 5 years ago

also interested about this issue.