search

pivotal-cf / terraforming-azure

use terraform, deploy yourself a pcf
Apache License 2.0
34 stars 67 forks source link

Moves isolation segment resources into a module #2

Closed ryanmoran closed 7 years ago

ryanmoran commented 7 years ago

Here is a spike I worked on to try out cleaning up some of our stuff using modules. To me, the advantages here are pretty good.

  1. the code for a set of resources is confined to a directory and not all over the place
  2. you can have a pretty "API" for using the module: saying isolation_segment = true instead of create_isoseg_resources = 1
  3. you can namespace your outputs: all of the isolation segment outputs can be grouped together
cf-gitbot commented 7 years ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

rainmaker commented 7 years ago

@ryanmoran looks good, it's a step in the right direction for reorganizing these TF templates

Are we able to remove the location field from all those resources? I was under the impression that we were blocked there until a bug was fixed? Maybe it required TF > v0.8.4, which we're pinning to?

ryanmoran commented 7 years ago

@rainmaker I am using terraform v0.8.4. But we should double check this.

zachgersh commented 7 years ago

merged but we are going to check that this actually applies from our machine before letting a pipeline run it 💃