pivotal-cf / terraforming-azure

use terraform, deploy yourself a pcf
Apache License 2.0
34 stars 67 forks source link

domain names created with env name #20

Closed fredwangwang closed 6 years ago

fredwangwang commented 6 years ago

The DNS entries that are being created include the env name in them. In previous implementations fo the azure terraforming, the user could provide the base domain, and prefixes for subsequent supported domains (ie custom sub domains for PCF, Opsman, etc).

We'd like to discuss removing the env name from the DNS entries.

-- @jtarchie && @fredwangwang

cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

genevieve commented 6 years ago

Since the other iaases prefix the dns zone and records with the environment name, we could accept a PR that introduces a new variable for a configurable dns zone name for azure. Since all the records are created and bound to the zone created here (https://github.com/pivotal-cf/terraforming-azure/blob/master/dns.tf#L2), we could allow the name of the zone to be configurable so that it doesn't force the domain to contain the environment name.

Does that sound good?

jtarchie commented 6 years ago

I think so. We might have to discuss some more customization around the names of the subdomains, too. Some people have require customization of the subdomain, so that it follows some internal naming convention.

rowanjacobs commented 6 years ago

Are you still interested in this feature? Would you be willing to submit a PR if so?

siennathesane commented 6 years ago

This would be a good feature to have. @rowanjacobs the ask is for a new parameter for DNS names, yeah?

rowanjacobs commented 6 years ago

That sounds correct.

siennathesane commented 6 years ago

@rowanjacobs see #24.

//cc @jtarchie @fredwangwang