Add support for multiple isolation segments based on a list of names

pivotal-cf / terraforming-azure

use terraform, deploy yourself a pcf

Apache License 2.0

34 stars 67 forks source link

Add support for multiple isolation segments based on a list of names #30

Open malston opened 6 years ago

malston commented 6 years ago

For each segment it will:

Add records with a dns name that includes the segment name in it
Create a new subnet that uses the bosh security group
Create public ips for each load balancer in the segment
Include diego-ssh and tcp load balancers in addition to the web lbs already defined.

cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

cdutra commented 5 years ago

Hi @malston, thanks for the PR!

According to the Reference Architecture you're supposed to configure only a load balancer for your Go Router in your Isolation Segment. The Diego SSH and TCP Router Load balancers come from the Shared Isolation Segment, therefore you don't need to create additional Diego SSH nor TCP Router LBs.

Could you please remove them from the PR, as well as address the aforementioned reviews, then we'll get it merged. Thanks again for the PR!

cc @ciriarte

sneal commented 5 years ago

@cdutra @malston I fixed a few issues that kept this from applying and added in the network security groups for isolation segments.

Removed the iso segment boolean variable. Enable/disable of iso segment is determined based off iso_seg_names and iso_seg_subnets having len > 0.
Added explicit list variable for configuring the iso segment subnet CIDRs. The calculation based on the vnet had too many assumptions baked into it.
Added in documented network security group rules for isolation segments.

sneal commented 5 years ago

I validated that I successfully deploy an isolation segment using the new isolation segment templates in this PR. I deployed an iso segment and was able to push an app to it.