search

pivotal-legacy / PivotalCoreKit

Shared library and test code for iOS and macOS projects
http://pivotallabs.com
Other
168 stars 85 forks source link

Backfill tests #137 #140

Closed tjarratt closed 9 years ago

tjarratt commented 9 years ago

I thought that @codeman9 had a good point in issuing pull request #137 -- it's important that our fakes behave as closely to the real thing as possible. Given only a subset of relevant methods for NSOperationQueue were implemented on the fake, it's all too easy to fall into the trap of assuming all of the relevant methods you can call on a real one would work on the fake as well. The end result of this (in my experience) is hard to debug tests and unhappy developers.

To that end, I backfilled tests for the proposed changes to -addOperations:waitUntilFinished: and -cancelAllOperations.

akitchen commented 9 years ago

Thanks @tjarratt @codeman9 for the patches.