search

pivotal-legacy / PivotalCoreKit

Shared library and test code for iOS and macOS projects
http://pivotallabs.com
Other
168 stars 85 forks source link

UIAlertController spec helpers behavior #161

Closed kseebaldt closed 8 years ago

kseebaldt commented 8 years ago

Dismiss the alert controller before calling the action. This reflects UIKit behavior.

kseebaldt commented 8 years ago

I'm wary of relying on PCK (especially stubs) to keep up to date with UIKit behavior. There were some tests on my current project that relied on this behavior.

akitchen commented 8 years ago

Argh, I merged this too soon. #152 is a more optimal way of factoring this, and has tests which cover it. I'll fix up and push

kseebaldt commented 8 years ago

Yes that is better. Don't trust everything I do ;)

akitchen commented 8 years ago

Thanks for bumping this issue, somehow it fell off our radar

On Wed, Sep 23, 2015 at 10:03 AM, Kurtis Seebaldt notifications@github.com wrote:

Yes that is better. Don't trust everything I do ;)

— Reply to this email directly or view it on GitHub https://github.com/pivotal/PivotalCoreKit/pull/161#issuecomment-142664140 .

idoru commented 8 years ago

Indeed; I think I was kicking the Travis can for a few days and got tired of watching the last time I hit retry ;)

--Sam

On Sep 23, 2015, at 1:04 PM, Andrew Kitchen notifications@github.com wrote:

Thanks for bumping this issue, somehow it fell off our radar

On Wed, Sep 23, 2015 at 10:03 AM, Kurtis Seebaldt notifications@github.com wrote:

Yes that is better. Don't trust everything I do ;)

— Reply to this email directly or view it on GitHub https://github.com/pivotal/PivotalCoreKit/pull/161#issuecomment-142664140 .

— Reply to this email directly or view it on GitHub.