akitchen
commented
9 years ago The Travis config is very easily changed. I think there should be a conversation about what our current min supported Xcode version should be.
What is the oldest Xcode watchers / users of PCK are supporting these days?
Otherwise, let's make sure everything else is in order and maybe cut one more release for older toolchains before a version bump
On Fri, Oct 30, 2015 at 7:25 PM, Brian Croom notifications@github.com wrote:
I've taken a pass at adding the appropriate nullability annotations to all the user-facing headers. Hopefully this will make things a bit smoother for folks trying to use PCK with Swift. It's worth noting that this does break compatibility with Xcode <6.3, which includes the version available on the default Travis image that we are running against. We may want to hold off on merging this until someone is able to spend some time modernizing our Travis configuration. You can view, comment on, or merge this pull request online at: https://github.com/pivotal/PivotalCoreKit/pull/168 -- Commit Summary --
- Add nullability annotations to the Foundation project
- Add nullability annotations to the CoreLocation project
- Add nullability annotations to the WatchKit project
Add nullability annotations to the UIKit project -- File Changes -- M CoreLocation/SpecHelper/Extensions/CLGeocoder+Spec.h (8) M CoreLocation/SpecHelper/Extensions/CLLocationManager+Spec.h (4) M Foundation/Core/Extensions/NSArray+PivotalCore.h (8) M Foundation/Core/Extensions/NSData+PivotalCore.h (4) M Foundation/Core/Extensions/NSDictionary+QueryString.h (4) M Foundation/Core/Extensions/NSDictionary+TypesafeExtraction.h (22) M Foundation/Core/Extensions/NSObject+MethodDecoration.h (4) M Foundation/Core/Extensions/NSObject+MethodRedirection.h (3) M Foundation/Core/Extensions/NSString+PivotalCore.h (4) M Foundation/Core/Extensions/NSURL+QueryComponents.h (4) M Foundation/Core/Extensions/PCKReducable.h (8) M Foundation/Core/Interfaces/PCKHTTPConnection.h (6) M Foundation/Core/Interfaces/PCKHTTPConnectionDelegate.h (10) M Foundation/Core/Interfaces/PCKHTTPConnectionOperation.h (6) M Foundation/Core/Interfaces/PCKHTTPInterface.h (12) M Foundation/Core/Monads/PCKCompletionHandler.h (8) M Foundation/Core/Monads/PCKErrorBlock.h (13) M Foundation/Core/Monads/PCKMaybeBlock.h (11) M Foundation/Core/Parsers/PCKParser.h (4) M Foundation/Core/Parsers/PCKParserDelegate.h (6) M Foundation/Core/Parsers/PCKResponseParser.h (6) M Foundation/Core/Parsers/PCKXMLParser.h (4) M Foundation/Core/Parsers/PCKXMLParserDelegate.h (12) M Foundation/Core/Parsers/PCKXMLParserDelegate.m (2) M Foundation/SpecHelper/Extensions/NSURLConnection+Spec.h (10) M Foundation/SpecHelper/Extensions/NSURLRequest+Spec.h (6) M Foundation/SpecHelper/Extensions/NSURLRequest+Spec.m (3) M Foundation/SpecHelper/Extensions/NSUUID+Spec.h (4) M Foundation/SpecHelper/Fakes/PSHKFakeHTTPURLResponse.h (12) M Foundation/SpecHelper/Fakes/PSHKFakeHTTPURLResponse.m (2) M Foundation/SpecHelper/Fakes/PSHKFakeOperationQueue.h (4) M Foundation/SpecHelper/Fakes/PSHKFakeResponses.h (4) M Foundation/SpecHelper/Fixtures/PSHKFixtures.h (4) M Foundation/SpecHelper/Helpers/PCKConnectionBlockDelegate.h (6) M Foundation/SpecHelper/Helpers/PCKConnectionDelegateWrapper.h (6) M UIKit/Core/Extensions/NSAttributedString+PivotalCoreKit_UIKit.h (4) M UIKit/Core/Extensions/NSString+PivotalCoreKit_UIKit.h (4) M UIKit/Core/Extensions/UIBarButtonItem+Button.h (6) M UIKit/Core/Extensions/UIImage+PivotalCore.h (4) M UIKit/Core/Extensions/UIImageView+PivotalCore.h (4) M UIKit/Core/Extensions/UIView+PCKNibHelpers.h (4) M UIKit/Core/Extensions/UIView+PivotalCore.h (4) M UIKit/SpecHelper/Extensions/UIBarButtonItem+Spec.h (3) M UIKit/SpecHelper/Extensions/UICollectionReusableView+Spec.h (8) M UIKit/SpecHelper/Extensions/UICollectionViewCell+Spec.h (8) M UIKit/SpecHelper/Extensions/UIControl+Spec.h (4) M UIKit/SpecHelper/Extensions/UIImage+Spec.h (4) M UIKit/SpecHelper/Extensions/UISegmentedControl+Spec.h (4) M UIKit/SpecHelper/Extensions/UITabBarController+Spec.h (4) M UIKit/SpecHelper/Extensions/UITableViewCell+Spec.h (8) M UIKit/SpecHelper/Extensions/UIView+Spec.h (8) M UIKit/SpecHelper/Extensions/UIWindow+Spec.h (6) M UIKit/SpecHelper/Extensions/iOS/UISlider+Spec.h (4) M UIKit/SpecHelper/Extensions/iOS/UISwitch+Spec.h (4) M UIKit/SpecHelper/Stubs/UIActivityViewController+Spec.h (6) M UIKit/SpecHelper/Stubs/UIAlertAction+Spec.h (8) M UIKit/SpecHelper/Stubs/UIAlertController+Spec.h (4) M UIKit/SpecHelper/Stubs/UIApplication+Spec.h (6) M UIKit/SpecHelper/Stubs/UIGestureRecognizer+Spec.h (4) M UIKit/SpecHelper/Stubs/UIPopoverController+Spec.h (6) M UIKit/SpecHelper/Stubs/UIView+StubbedAnimation.h (10) M UIKit/SpecHelper/Stubs/UIView+StubbedGestureRecognizers.h (4) M UIKit/SpecHelper/Stubs/UIViewController+Spec.h (4) M UIKit/SpecHelper/Stubs/iOS/UIActionSheet+Spec.h (11) M UIKit/SpecHelper/Stubs/iOS/UIAlertView+Spec.h (6) M UIKit/SpecHelper/Stubs/iOS/UIImagePickerController+Spec.h (4) M UIKit/SpecHelper/Stubs/iOS/UITableViewRowAction+Spec.h (8) M UIKit/SpecHelper/Stubs/iOS/UIWebView+Spec.h (16) M UIKit/SpecHelper/Support/PCKMethodRedirector.h (4) M UIKit/SpecHelper/Support/PCKPrototypeCellInstantiatingDataSource.h (4) M WatchKit/Specs/WatchKit/WKInterfaceControllerSpec.mm (2) M WatchKit/WatchKit/NSInvocation+InvocationMatching.h (6) M WatchKit/WatchKit/PCKFakeSegue.h (4) M WatchKit/WatchKit/PCKInterfaceControllerLoader.h (13) M WatchKit/WatchKit/PCKInterfaceControllerLoader.m (6) M WatchKit/WatchKit/PCKMessageCapturer.h (3) M WatchKit/WatchKit/PCKWKInterfaceControllerProvider.h (3) M WatchKit/WatchKit/PCKWKInterfaceObjectProvider.h (3) M WatchKit/WatchKit/UIColor+PCK_StringToColor.h (3) M WatchKit/WatchKit/WKExtension+Spec.h (6) M WatchKit/WatchKit/WKInterfaceButton+Spec.h (15) M WatchKit/WatchKit/WKInterfaceButton.h (15) M WatchKit/WatchKit/WKInterfaceController.h (40) M WatchKit/WatchKit/WKInterfaceDate+Spec.h (7) M WatchKit/WatchKit/WKInterfaceDate.h (10) M WatchKit/WatchKit/WKInterfaceDevice.h (4) M WatchKit/WatchKit/WKInterfaceGroup+Spec.h (3) M WatchKit/WatchKit/WKInterfaceGroup.h (11) M WatchKit/WatchKit/WKInterfaceImage+Spec.h (5) M WatchKit/WatchKit/WKInterfaceImage.h (11) M WatchKit/WatchKit/WKInterfaceLabel+Spec.h (10) M WatchKit/WatchKit/WKInterfaceLabel.h (9) M WatchKit/WatchKit/WKInterfaceMap.h (7) M WatchKit/WatchKit/WKInterfaceObject+Spec.h (3) M WatchKit/WatchKit/WKInterfaceObject.h (3) M WatchKit/WatchKit/WKInterfaceSeparator+Spec.h (5) M WatchKit/WatchKit/WKInterfaceSeparator.h (5) M WatchKit/WatchKit/WKInterfaceSlider+Spec.h (7) M WatchKit/WatchKit/WKInterfaceSlider.h (5) M WatchKit/WatchKit/WKInterfaceSwitch+Spec.h (3) M WatchKit/WatchKit/WKInterfaceSwitch.h (3) M WatchKit/WatchKit/WKInterfaceTable+Spec.h (3) M WatchKit/WatchKit/WKInterfaceTable.h (5) M WatchKit/WatchKit/WKInterfaceTimer+Spec.h (3) M WatchKit/WatchKit/WKInterfaceTimer.h (5) M WatchKit/WatchKit/WKUserNotificationInterfaceController+Spec.h (8) -- Patch Links -- https://github.com/pivotal/PivotalCoreKit/pull/168.patch https://github.com/pivotal/PivotalCoreKit/pull/168.diff
Reply to this email directly or view it on GitHub: https://github.com/pivotal/PivotalCoreKit/pull/168
I've taken a pass at adding the appropriate nullability annotations to all the user-facing headers. Hopefully this will make things a bit smoother for folks trying to use PCK with Swift.
It's worth noting that this does break compatibility with Xcode <6.3, which includes the version available on the default Travis image that we are running against. We may want to hold off on merging this until someone is able to spend some time modernizing our Travis configuration.