search

pivotal-legacy / PivotalCoreKit

Shared library and test code for iOS and macOS projects
http://pivotallabs.com
Other
168 stars 85 forks source link

Update the PCKNibHelper’s NSLayoutConstraints to pass on the identifier and priority. #195

Closed xtreme-andy-shen closed 7 years ago

xtreme-andy-shen commented 7 years ago

Turn off auto resizing mask.

As authored by @xtreme-lisheng-tai & @briancroom

akitchen commented 7 years ago

Thanks @xtreme-andy-shen @xtreme-lisheng-tai & @briancroom

These changes seem more correct and accommodating than what we had recently -- just need to get travis stabilized before we can merge.

Appreciate the pr's and everyone's patience!

akitchen commented 7 years ago

I think we're good to merge once Travis passes on master. Hang tight...

xtreme-andy-shen commented 7 years ago

👍

tjarratt commented 7 years ago

Should we include a small test that verifies we copy over the identifier and priority? It seems to me that change is important, and having a test that documents that happens would be useful if we ever end up wildly refactoring these categories.

tjarratt commented 7 years ago

I do want to say that I'm delighted to see these pull requests. You're awesome @xtreme-andy-shen!

xtreme-andy-shen commented 7 years ago

@tjarratt Cool, I'll add them

xtreme-andy-shen commented 7 years ago

Done.

tjarratt commented 7 years ago

Thanks!