search

pivotal-legacy / PivotalCoreKit

Shared library and test code for iOS and macOS projects
http://pivotallabs.com
Other
168 stars 85 forks source link

Multiple fixes iOS 13.4 #210

Closed tomquist closed 4 years ago

tomquist commented 4 years ago

Swizzle all methods instead of overriding them in categories which requires defined loading order.

This fixes most of the tests in iOS 13.4

tjarratt commented 4 years ago

Oooooh a PR, nice. Ill try my best to take a look at this soon.

Sent From A Very Small Keyboard

Le 31 mars 2020 à 16:49, tomquist notifications@github.com a écrit :

 Swizzle all methods instead of overriding them in categories which requires defined loading order.

This fixes most of the tests in iOS 13.4

You can view, comment on, or merge this pull request online at:

https://github.com/pivotal-legacy/PivotalCoreKit/pull/210

Commit Summary

Multiple fixes iOS 13.4 File Changes

M UIKit/Spec/Stubs/UIViewControllerSpec+Spec.mm (6) M UIKit/SpecHelper/Extensions/UITableViewCell+Spec.m (4) M UIKit/SpecHelper/Stubs/UIAlertController+Spec.m (8) M UIKit/SpecHelper/Stubs/UIApplication+Spec.m (4) M UIKit/SpecHelper/Stubs/UINavigationController+Spec.m (11) M UIKit/SpecHelper/Stubs/iOS/UIActionSheet+Spec.m (16) M UIKit/SpecHelper/Stubs/iOS/UIAlertView+Spec.m (11) M UIKit/SpecHelper/Stubs/iOS/UIImagePickerController+Spec.h (2) M UIKit/SpecHelper/Stubs/iOS/UIImagePickerController+Spec.m (16) M UIKit/SpecHelper/Stubs/iOS/UIWebView+Spec.m (22) M UIKit/SpecHelper/Support/PCKMethodRedirector.h (2) M UIKit/SpecHelper/Support/PCKMethodRedirector.m (34) Patch Links:

https://github.com/pivotal-legacy/PivotalCoreKit/pull/210.patch https://github.com/pivotal-legacy/PivotalCoreKit/pull/210.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

akitchen commented 4 years ago

haha I had the same thought -- thanks so much for the PR @tomquist , these sound like much-needed updates to keep the libraries reliably useful

tjarratt commented 4 years ago

Thanks again for your PR @tomquist. I noticed that a few other specs were failing, namely the UITableViewCell specs related tapping to the delete accessory. Were those failing for you as well ? I tried to see what was causing that, but didn't see anything obvious.

tomquist commented 4 years ago

Unfortunately these were the only specs I could get to pass again. The reason for them to fail is that tapping the delete button doesn't have an effect anymore. I investigated quite some time to find out what is going on even by looking at the disassembly of UIKit using Hopper but without success.