search

pivotal-legacy / homebrew-tap

33 stars 49 forks source link

Depend on openjdk instead of java #177

Closed duanemay closed 3 years ago

duanemay commented 3 years ago

Eliminates error while tapping Error: Invalid formula: /usr/local/Homebrew/Library/Taps/pivotal/homebrew-tap/trilogy.rb trilogy: Calling depends_on :java is disabled! Use "depends_on "openjdk@11", "depends_on "openjdk@8" or "depends_on "openjdk" instead. Please report this issue to the pivotal/tap tap (not Homebrew/brew or Homebrew/core), or even better, submit a PR to fix it: /usr/local/Homebrew/Library/Taps/pivotal/homebrew-tap/trilogy.rb:9

chenrui333 commented 3 years ago

For folks who are waiting for this change to be merged, this is my temporary solution, https://stackoverflow.com/a/65474366/791609

minz-github commented 3 years ago

For folks who are waiting for this change to be merged, this is my temporary solution, https://stackoverflow.com/a/65474366/791609

Thanks @chenrui333 and how did you work it out? As I got the following error, or do you know how to deal with this?

$brew edit trilogy Usage: brew edit [formula|cask]

Open a formula or cask in the editor set by EDITOR or HOMEBREW_EDITOR, or open the Homebrew repository for editing if no formula is provided.

  --formula, --formulae        Treat all named arguments as formulae.
  --cask, --casks              Treat all named arguments as casks.

-d, --debug Display any debugging information. -q, --quiet Make some output more quiet. -v, --verbose Make some output more verbose. -h, --help Show this message.

Error: Invalid usage: trilogy doesn't exist on disk. Run brew create --set-name trilogy $URL to create a new Formula!

chenrui333 commented 3 years ago

@minz-github you need to brew tap pivotal/tap first.

minz-github commented 3 years ago

brew tap pivotal/tap

Yes, I did and failed at this step as below:

$ brew tap pivotal/tap ==> Tapping pivotal/tap Cloning into '/usr/local/Homebrew/Library/Taps/pivotal/homebrew-tap'... remote: Enumerating objects: 39, done. remote: Counting objects: 100% (39/39), done. remote: Compressing objects: 100% (30/30), done. remote: Total 1474 (delta 19), reused 21 (delta 9), pack-reused 1435 Receiving objects: 100% (1474/1474), 281.73 KiB | 8.05 MiB/s, done. Resolving deltas: 100% (842/842), done. Error: Invalid formula: /usr/local/Homebrew/Library/Taps/pivotal/homebrew-tap/trilogy.rb trilogy: Calling depends_on :java is disabled! Use "depends_on "openjdk@11", "depends_on "openjdk@8" or "depends_on "openjdk" instead. Please report this issue to the pivotal/tap tap (not Homebrew/brew or Homebrew/core), or even better, submit a PR to fix it: /usr/local/Homebrew/Library/Taps/pivotal/homebrew-tap/trilogy.rb:9

Error: Cannot tap pivotal/tap: invalid syntax in tap!

chenrui333 commented 3 years ago

I see, give this a try.

And then do the regular brew edit trilogy, gonna update my SO answer. Thanks for flagging this out.

minz-github commented 3 years ago

Cool, it works for me, thanks @chenrui333 and Happy New Year!

chenrui333 commented 3 years ago

Happy new year!

TildeWill commented 3 years ago

Ran in to this today trying to install git-author. Would love to see this merged in soon. Thanks @chenrui333 for the SO and the PR!

onichols-pivotal commented 3 years ago

@philwebb @snicoll @jkonicki could someone please merge this at your earliest convenience? The entire pivotal tap has been unusable for weeks and this is the last fix needed to make it work again.

philwebb commented 3 years ago

@onichols-pivotal I've no idea who own trilogy.rb but I've merged the PR anyway. Hopefully they won't mind.