pivotal-legacy / homebrew-tap

33 stars 49 forks source link

Fixed broken sha again. Should be stable now. #39

Closed jberkhahn closed 9 years ago

jberkhahn commented 9 years ago

Sorry about these repeated PRs. We've been monkeying around with our build and release pipeline, and it's been rebuilding the release tar.

goehmen commented 9 years ago

@nebhale Hey - getting this pulled in before the weekend would be good. sha mismatches kind of make CF folks nervous. Thanks

gerhard commented 9 years ago

Yes please. Can I also suggest that this is done by the CI, with release code that gets them same care & attention as everything else :wink:

nebhale commented 9 years ago

@jberkhahn Can you guys please put something on your backlog to ensure the proper hashes? If you take a look at the history of these PRs there are quite a number of mismatches. I suspect that there's just a misunderstanding that the SHA is the binary and not the commit, and that the turnover on the team means that the knowledge isn't being socialized.