greenplum-db fails to build

[ccheetham]

OSX version 10.12.5

% uname -a
Darwin pivot 16.6.0 Darwin Kernel Version 16.6.0: Fri Apr 14 16:21:16 PDT 2017; root:xnu-3789.60.24~6/RELEASE_X86_64 x86_64

Error

% brew install greenplum-db
...
==> Installing greenplum-db from pivotal/tap
==> Downloading https://github.com/greenplum-db/gpdb/archive/5.0.0-beta.2.tar.gz
...
==> make install
Last 15 lines from /Users/ccheetham/Library/Logs/Homebrew/greenplum-db/03.make:
  utils/pg_locale.h              includes missing file "locale.h"
  utils/string_wrapper.h         includes missing file "string.h"
  utils/string_wrapper.h         includes missing file "errno.h"
  utils/timestamp.h              includes missing file "math.h"
  utils/timestamp.h              includes missing file "limits.h"
  utils/varbit.h                 includes missing file "limits.h"
  utils/zlib_wrapper.h           includes missing file "zlib.h"
Include files... FAILED
make[2]: *** [includecheck] Error 1
make[2]: *** Waiting for unfinished jobs....
clang -no-cpp-precomp -O3 -std=gnu99  -Wall -Wmissing-prototypes -Wpointer-arith -Wendif-labels -Wformat-security -fno-strict-aliasing -fwrapv -Wno-address   -L../../src/port -L../../src/port    -bundle -bundle_loader ../../src/backend/postgres -o autoinc.so autoinc.o
clang -no-cpp-precomp -O3 -std=gnu99  -Wall -Wmissing-prototypes -Wpointer-arith -Wendif-labels -Wformat-security -fno-strict-aliasing -fwrapv -Wno-address   -L../../src/port -L../../src/port    -bundle -bundle_loader ../../src/backend/postgres -o refint.so refint.o
rm refint.o autoinc.o
make[1]: *** [install] Error 2
make: *** [install] Error 2

If reporting this issue please do so to (not Homebrew/brew or Homebrew/core):
pivotal/tap

[nebhale]

@xinzweb Looks like your PR #90 broke the tap.

[ccheetham]

@xinzweb This is still broken for me as of 32eba7abc8b2b6cce5d6923db855ccb7ec488697

[xinzweb]

Thanks a lot @ccheetham. I am using

xzhangs-Mac:greenplum-db xzhang$ uname -a
Darwin xzhangs-Mac.local 16.6.0 Darwin Kernel Version 16.6.0: Fri Apr 14 16:21:16 PDT 2017; root:xnu-3789.60.24~6/RELEASE_X86_64 x86_64

The new PR works fine on that box.

xzhangs-Mac:greenplum-db xzhang$ clang --version
Apple LLVM version 8.1.0 (clang-802.0.42)
Target: x86_64-apple-darwin16.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

What's your clang version? Thanks.

[ccheetham]

% clang --version
Apple LLVM version 8.1.0 (clang-802.0.42)
Target: x86_64-apple-darwin16.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

[ccheetham]

Set my developer to match yours ...

% sudo xcode-select -s /Library/Developer/CommandLineTools

After making change, greenplum-db built and installed.

[xinzweb]

Glad it works. I will close the issue. I may consider to add another line to the formula to give people hint to use the commandline.