search

pivotal-sprout / sprout-wrap

Pivotal Labs uses this project with sprout, soloist and librarian-chef to build developer workstations
The Unlicense
157 stars 250 forks source link

Adds an externally managed sprout-terminal cookbook #25

Closed codeword closed 10 years ago

codeword commented 10 years ago

This commit adds the sprout-terminal cookbook to sprout-wrap. This cookbook is managed outside of the core sprout repository and can be used as an example for how to define custom cookbooks to be included in sprout-wrap.

Without changing any configuration the sprout-terminal cookbook will simply set the startup and default profiles to 'Basic' (which is the mac osx default) and will set the 'close window' setting to 'when terminal exits cleanly'.

hiremaga commented 10 years ago

Looks good to me.

I'd suggest following up with a couple of changes:

  1. Rename sprout-terminal to sprout-osx-terminal
  2. Move sprout-osx-terminal to the pivotal-sprout account (I can do this is you make me an owner of sprout-terminal)

Neither of these changes need block merging this in but I'll let you and @cunnie do this since I'm not setup to test these changes rigorously right now.

hiremaga commented 10 years ago

Changed my mind about the name of the cookbook, metadata.rb already specifies its OS compatibility so there's no need to say "osx" in the name :)