cask name change fix, and some minor additions

[gambtho]

Really enjoying using sprout-wrap. Noticed that gitx wasn't installing, looks like the cask name may have changed. While fixing that, felt that the CF CLI should really be part of the base install, and added some more FAQs based on things I'd heard from others who were using it.

[wendorf]

Hi @gambtho ,

Thanks for the contribution! Since this is really a few separate changes (fixing gitx, adding the CLI, and putting notes on the README) would you mind submitting those as separate PRs that can be merged independently?

• The CLI PR will need to install the custom taps before using them (check the Travis failure to see what I mean). Note: cloudfoundry-cli is available on homebrew cask, but lags a bit behind the formula in pivotal/tap. I'm not sure what we should prefer, but it should either be 1) installing pivotal/tap and using its cloudfoundry-cli formula, or 2) not installing custom taps and using the cask instead.
• caskroom/versions isn't a chef recipe, so the wording on the FAQ patch should be updated
• Can you trim the additional newlines on the FAQ?
• For these changes, please use git's fixup capabilities to keep the git history clean.

Thanks again! Dan Wendorf

[gambtho]

Thanks for the quick response — resubmitted per your requests.

Tom

From: Dan Wendorf notifications@github.com<mailto:notifications@github.com> Reply-To: pivotal-sprout/sprout-wrap reply@reply.github.com<mailto:reply@reply.github.com> Date: Sunday, November 8, 2015 at 4:07 PM To: pivotal-sprout/sprout-wrap sprout-wrap@noreply.github.com<mailto:sprout-wrap@noreply.github.com> Cc: Thomas Gamble Thomas_Gamble@homedepot.com<mailto:Thomas_Gamble@homedepot.com> Subject: Re: [sprout-wrap] cask name change fix, and some minor additions (#76)

Hi @gambthohttps://github.com/gambtho ,

Thanks for the contribution! Since this is really a few separate changes (fixing gitx, adding the CLI, and putting notes on the README) would you mind submitting those as separate PRs that can be merged independently?

• The CLI PR will need to install the custom taps before using them (check the Travis failurehttps://travis-ci.org/pivotal-sprout/sprout-wrap/builds/89976943 to see what I mean). Note: cloudfoundry-clihttps://github.com/caskroom/homebrew-cask/blob/master/Casks/cloudfoundry-cli.rb is available on homebrew cask, but lags a bit behind the formula in pivotal/taphttps://github.com/pivotal/homebrew-tap/blob/master/cloudfoundry-cli.rb. I'm not sure what we should prefer, but it should either be 1) installing pivotal/tap and using its cloudfoundry-cli formula, or 2) not installing custom taps and using the cask instead.
• caskroom/versions isn't a chef recipe, so the wording on the FAQ patch should be updated
• Can you trim the additional newlines on the FAQ?
• For these changes, please use git's fixuphttps://www.atlassian.com/git/tutorials/merging-vs-rebasing/the-golden-rule-of-rebasing capabilities to keep the git history clean.

Thanks again! Dan Wendorf

— Reply to this email directly or view it on GitHubhttps://github.com/pivotal-sprout/sprout-wrap/pull/76#issuecomment-154871852.

---

The information in this Internet Email is confidential and may be legally privileged. It is intended solely for the addressee. Access to this Email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited and may be unlawful. When addressed to our clients any opinions or advice contained in this Email are subject to the terms and conditions expressed in any applicable governing The Home Depot terms of business or client engagement letter. The Home Depot disclaims all responsibility and liability for the accuracy and content of this attachment and for any damages or losses arising from any inaccuracies, errors, viruses, e.g., worms, trojan horses, etc., or other items of a destructive nature, which may be contained in this attachment and shall not be liable for direct, indirect, consequential or special damages in connection with this e-mail message or its attachment.