pivotal-sprout / sprout-wrap

Pivotal Labs uses this project with sprout, soloist and librarian-chef to build developer workstations
The Unlicense
157 stars 250 forks source link

Readme improvements #87

Closed spilth closed 8 years ago

spilth commented 8 years ago

I updated the README to put the installation directions right in a user's face.

Also using bundle --path vendor/bundle to try and not screw with system Ruby as much as possible.

mikfreedman commented 8 years ago

+1

hiremaga commented 8 years ago

Thanks @spilth!

I recall going to some lengths to avoid a full XCode install and instead installing just the CLI tools with xcode-select. Is the change back to a full XCode install necessary?

spilth commented 8 years ago

When I tried to install sprout-vim it complained that it needed XCode.

hiremaga commented 8 years ago

Ah :) we've gone back and forth about how whether to use the cask or formula for macvim, the latter needs all of XCode. The only remaining dependency.

+1 to this PR @wendorf On Mon, Feb 1, 2016 at 3:55 PM Brian Kelly notifications@github.com wrote:

When I tried to install sprout-vim it complained that it needed XCode.

— Reply to this email directly or view it on GitHub https://github.com/pivotal-sprout/sprout-wrap/pull/87#issuecomment-178264683 .

mikfreedman commented 8 years ago

+1

hiremaga commented 8 years ago

@wendorf I took a liberty... ;)

aramprice commented 8 years ago

@hiremaga regarding full Xcode install - I have repeatedly had problems successfully running gem install nokogiri on a fresh El Capitain machine until a full version of Xcode is installed via the App Store. Using a .dmg based install or using the CLI tools did not work.

I believe the sprout-vim issue is because that cookbook compiles macvim in order to include lua support. @luan would have more context.

hiremaga commented 8 years ago

@aramprice I wonder if it's the version of Xcode rather than whether it's via one source or another. I have a theory that nokogiri and Xcode versions play a cat and mouse game, so every time a new version of Xcode is out a new version of nokogiri is needed for it to compile correctly.

And, I think you're right about sprout-vim and lua support. We'd be able to able to stop compiling the macvim if somebody (@luan, koff koff) maintained a binary tap with a lua friendly version of macvim. On Thu, Apr 14, 2016 at 9:24 AM aram price notifications@github.com wrote:

@hiremaga https://github.com/hiremaga regarding full Xcode install - I have repeatedly had problems successfully running gem install nokogiri on a fresh El Capitain machine until a full version of Xcode is installed via the App Store. Using a .dmg based install or using the CLI tools did not work.

I believe the sprout-vim issue is because that cookbook compiles macvim in order to include lua support. @luan https://github.com/luan would have more context.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/pivotal-sprout/sprout-wrap/pull/87#issuecomment-209687988

aramprice commented 8 years ago

FWIW I had trouble again trying to install nokogiri this time with the latest Xcode, and latest nokogir on El Capitan, using system ruby, latest bundler and latest ruby gems code.

On a different machine with the same configuration nokogiri compiled fine.

We worked around this by dropping foodcritic - it is the only gem in our sprout-exemplar that requires nokogiri :-/