pivotal / LicenseFinder

Find licenses for your project's dependencies.
MIT License
1.72k stars 339 forks source link

Generated yaml is hard to review manually due to use of repeated nodes syntax #803

Open hlascelles opened 3 years ago

hlascelles commented 3 years ago

We use the generated yaml to both drive the tool in CI, but also for to eyeball sometimes to see who did what.

The generated yaml uses repeated nodes syntax to reduce repetition.

image

This makes it hard to scan the file and see what is going on.

Would you be open to a PR (haven't looked if it is easy yet) to disable them (if possible!).

cf-gitbot commented 3 years ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

xtreme-shane-lattanzio commented 3 years ago

Hey @hlascelles I think this can be useful as an optional flag to disable it. I am guessing this is happening around line 291 of decisions.rb. The safe_yaml gem dump command seems to be consolidating things. Thanks for looking into this!