pivotal / blog

Pivotal Engineering Blog
https://engineering.pivotal.io/
40 stars 47 forks source link

Draft post on Vim #189

Closed Petahhh closed 6 years ago

Petahhh commented 6 years ago

Signed-off-by: Peter Tran ptran@pivotal.io

osis commented 6 years ago

Haha so many gifs. Amazing!

osis commented 6 years ago

Going through the content take a good bit of scrolling. Have you explored use the left and right styles to get more of a two column format?

ex.

screen shot 2017-11-06 at 10 05 58 am
osis commented 6 years ago

Format suggestions:

  1. Put movement first
  2. Put "Insert Mode" before "Text Manipulation" since those put you into insert mode anyways
Petahhh commented 6 years ago

@osis I moved the sections around as you suggested. I also experimenting with using tables in the movement section. I created two columns and alternated the gifs from the left to right side. I thought it gave it a better visual break. Let me know if you think it's okay and I'll apply it to the rest of the post. (Vim macros to the rescue!)

osis commented 6 years ago

I'm personally a fan of keeping content in the same column for readability, but that's up to you. Like what you did with the tables! Feel free to play with the format as well. Maybe explain the movie HJKL and put all four GIFs in a grid below?

Petahhh commented 6 years ago

@osis Updated and squashed the commits. Let me know if it's okay and I'll publish it and update the date

osis commented 6 years ago

I would double-check header sizes for consistency and maybe check out the Pivotal UI Typography page to see how your instructions can "pop".

Seems fine though. Always feel free to publish; you can always adjust after if you'd like.

Petahhh commented 6 years ago

@osis I've updated the PR to officially publish the post and updated the date. Could you please accept it? I see that I don't have write permissions yet.